Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update #3347

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Translations update #3347

merged 1 commit into from
Sep 30, 2024

Conversation

RiotRobot
Copy link
Collaborator

  • Translations update

@RiotRobot RiotRobot requested a review from a team as a code owner September 30, 2024 00:01
@RiotRobot RiotRobot removed the request for review from a team September 30, 2024 00:01
@RiotRobot RiotRobot added the pr-i18n for translations label Sep 30, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against 75fd404

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

codecov bot commented Sep 30, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
676 2 674 0
View the top 1 failed tests by shortest run time
DateTests testMinimalDateFormatting()
Stack Traces | 0.003s run time
XCTAssertEqual failed: ("Yesterday") is not equal to ("23 hours ago") (.../UnitTests/Sources/DateTests.swift:22)
View the full list of 1 ❄️ flaky tests
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 27.87% (Passed 44 times, Failed 17 times)

Stack Traces | 10.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@stefanceriu stefanceriu merged commit 46263cc into develop Sep 30, 2024
7 of 9 checks passed
@stefanceriu stefanceriu deleted the translations/update branch September 30, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-i18n for translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants