Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new emoji from iOS 17.4 to the reaction picker. #3376

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 8, 2024

Our Emojibase package now generates unicode 15.1 emoji on iOS so this PR updates it to get the emoji added in iOS 17.4 πŸ¦β€πŸ”₯

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-08.at.10.31.40.mp4

@pixlwave pixlwave requested a review from a team as a code owner October 8, 2024 09:32
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 8, 2024 09:32
Copy link

github-actions bot commented Oct 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 46f2912

@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

@pixlwave pixlwave merged commit a7f7fde into develop Oct 8, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/emoji-base branch October 8, 2024 10:15
Copy link

codecov bot commented Oct 8, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
840 3 837 0
View the full list of 3 ❄️ flaky tests
PreviewTests test_identityConfirmationScreen()

Flake rate in main: 24.14% (Passed 44 times, Failed 14 times)

Stack Traces | 1.1s run time
failed - Snapshot does not match reference.

@βˆ’
"file:.../__Snapshots__/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"
@+
"file:.../tmp/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.94485474 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_serverSelection()

Flake rate in main: 26.32% (Passed 28 times, Failed 10 times)

Stack Traces | 3.81s run time
failed - Snapshot does not match reference.

@βˆ’
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8937988 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_loginScreen()

Flake rate in main: 32.63% (Passed 64 times, Failed 31 times)

Stack Traces | 20.9s run time
failed - Snapshot "matrix.org" does not match reference.

@βˆ’
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants