Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member Panel - PR 2 - UI #417

Merged
merged 36 commits into from
Aug 6, 2021
Merged

Member Panel - PR 2 - UI #417

merged 36 commits into from
Aug 6, 2021

Conversation

MidhunSureshR
Copy link
Member

No description provided.

@MidhunSureshR
Add method to get member from storage
05f05bb 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Indicate if no member found
3aeb0c4 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Support state events
6cfb4cf 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
bwindels
bwindels reviewed Aug 2, 2021
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first round of review, looking good!

src/domain/navigation/index.js Outdated Show resolved Hide resolved
src/domain/session/rightpanel/MemberDetailsViewModel.js Outdated Show resolved Hide resolved
src/domain/session/rightpanel/MemberDetailsViewModel.js Outdated Show resolved Hide resolved
src/domain/session/rightpanel/MemberDetailsViewModel.js Outdated Show resolved Hide resolved
src/platform/web/ui/session/rightpanel/MemberDetailsView.js Outdated Show resolved Hide resolved
src/platform/web/ui/session/rightpanel/MemberDetailsView.js Show resolved Hide resolved
src/platform/web/ui/session/rightpanel/MemberDetailsView.js Outdated Show resolved Hide resolved
@MidhunSureshR
Fetch member data from from state event if needed
bb68b4d 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Return null on error
e363d32 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Return null
c9a4c39 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR MidhunSureshR changed the title [WIP] - Member Panel - UI Member Panel - PR 2 - UI Aug 5, 2021
@MidhunSureshR
Return null
7e48108 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Create vm and view
fdd4caa 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Create navigation and add to right panel
e4bb205 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Add license headers
acdba8f 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Add basic UI and styling
7ef7c41 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Add isEncrypted to vm
c2b9c3f 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Improve code and css
c9224c1 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Use powerlevel
fe6551f 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Add links
f9b1068 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Fallback to memberlist if member not available
ef17808 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Improve segment adding logic
7530b28 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Show back button
7dacbdb 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Add link to open member details
65b1a19 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Make the tiles link to details
4784bcc 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Style tile
448bf3c 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Better formatting
16887c3 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Keep memberlist until rightpanel is closed
d056a9f 
- This should make switching between memberlist and
  member-details panel smoother for large rooms

Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Remove dm user option
0ff0850 
- I don't know why but I thought .../open-room/<user_id> would open an
  invite view to a room with the specified user.
- Does not work like that, so removed.

Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Copy over all segments after right-panel
28a0a08 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Create getter
a16c3aa 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Describe what changed in emitChange()
862e856 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Use i8n in role
d3ea26a 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Use texttransform
fea4143 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@MidhunSureshR
Remove object
49be4e6 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
R Midhun Suresh and others added 2 commits August 6, 2021 13:02
@bwindels
Don't cache powerlevel value
974d9bf 
Co-authored-by: Bruno Windels <bruno@windels.cloud>
@MidhunSureshR
Only need to emit
86ddfc1 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
bwindels
bwindels approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, but basically looks good to go

src/domain/session/rightpanel/MemberDetailsViewModel.js Outdated Show resolved Hide resolved
src/domain/session/rightpanel/RightPanelViewModel.js Outdated Show resolved Hide resolved
src/platform/web/ui/session/rightpanel/MemberDetailsView.js Show resolved Hide resolved
src/platform/web/ui/session/rightpanel/RightPanelView.js Show resolved Hide resolved
MidhunSureshR and others added 4 commits August 6, 2021 16:03
@MidhunSureshR
Remove unused prop
dbd2057 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@bwindels
No need for lambda here
3ff5520 
Co-authored-by: Bruno Windels <bruno@windels.cloud>
@MidhunSureshR
Merge suggestion from Github
bc8e623
@MidhunSureshR
Refactor map into switch-case
7e8d76a 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
@bwindels bwindels self-requested a review August 6, 2021 11:18
bwindels
bwindels approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good to go!

@bwindels bwindels merged commit 1862e31 into element-hq:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MidhunSureshR @bwindels