Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Messages with code blocks show other HTML as plain text #2280

Closed
tulir opened this issue May 20, 2018 · 6 comments
Closed

Messages with code blocks show other HTML as plain text #2280

tulir opened this issue May 20, 2018 · 6 comments
Assignees
Milestone

Comments

@tulir
Copy link

tulir commented May 20, 2018

Riot Web:
image

Riot Android 0.8.9-dev G-#2115:
image

Message:

{
  "origin_server_ts": 1526827110060,
  "sender": "@tulir:maunium.net",
  "event_id": "$15268271104664MjwaS:maunium.net",
  "unsigned": {
    "age": 276,
    "transaction_id": "m1526827109769.32"
  },
  "content": {
    "body": "**h**<u>t</u>_m_<del>l</del>\n```\ncode block\n```",
    "msgtype": "m.text",
    "formatted_body": "<p><strong>h</strong><u>t</u><em>m</em><del>l</del></p>\n<pre><code>code block\n</code></pre>\n",
    "format": "org.matrix.custom.html"
  },
  "type": "m.room.message",
  "room_id": "!GnEEPYXUhoaHbkFBNX:matrix.org"
}

Possibly related to #1973: Pills also show up as raw HTML in messages with code blocks.

@jaylik
Copy link
Contributor

jaylik commented May 26, 2018

riot-web 0.15.4:
image

Riot Android 0.8.9 (G-b137)
screenshot_20180526-105935_riot im

{
  "origin_server_ts": ...,
  "sender": "@...",
  "event_id": "$...:node.fi",
  "unsigned": {
    "age": ...
  },
  "content": {
    "body": "[PROBLEM] test.host.fi: Service TestLocation:\nEvent time: 2018.05.11 18:47:05\nRecovery time: 2018.05.11 19:10:04",
    "msgtype": "m.text",
    "formatted_body": "<strong><font color=\"red\">[PROBLEM]</font> test.host.fi: Service Test</strong><br /><pre><code>Location:\nEvent time: 2018.05.11 18:47:05\nRecovery time: 2018.05.11 19:10:04</code></pre>",
    "format": "org.matrix.custom.html"
  },
  "type": "m.room.message",
  "room_id": "!...:node.fi"
}
{
  "origin_server_ts": ...,
  "sender": "@...:node.fi",
  "event_id": "$...:node.fi",
  "unsigned": {
    "age": ...
  },
  "content": {
    "body": "[RECOVERY] test.host.fi: Service TestLocation:\nEvent time: 2018.05.11 18:47:06\nRecovery time: 2018.05.11 19:10:05",
    "msgtype": "m.text",
    "formatted_body": "<strong><font color=\"green\">[RECOVERY]</font> test.host.fi: Service Test</strong><br /><pre><code>Location:\nEvent time: 2018.05.11 18:47:06\nRecovery time: 2018.05.11 19:10:05</code></pre>",
    "format": "org.matrix.custom.html"
  },
  "type": "m.room.message",
  "room_id": "!...:node.fi"
}

@bmarty bmarty self-assigned this May 29, 2018
@bmarty
Copy link
Member

bmarty commented May 29, 2018

I cannot reproduce the issue with latest dev build.

@Shadow53
Copy link

Shadow53 commented Jun 11, 2018

Multiple users in #Linux:matrix.org have been able to confirm that this issue occurs on the F-Droid build of Riot, version 0.8.10. One user in the group did not have the issue and they were using the Play Store build.

Correction: Two users both are using the Play Store version; one has the issue, one doesn't.

@tulir
Copy link
Author

tulir commented Jun 12, 2018

Still an issue as of 0.8.13-dev G-b2238, also confirmed on F-b2238

@bmarty bmarty added this to the Sprint 12 milestone Jul 9, 2018
@bmarty
Copy link
Member

bmarty commented Jul 9, 2018

@bmarty
Copy link
Member

bmarty commented Jul 13, 2018

Issue reproduced when entering:

**bold**
```
code
```

bmarty added a commit that referenced this issue Jul 16, 2018
Messages with code blocks show other HTML as plain text (#2280)
giomfo referenced this issue in tchapgouv/tchap-android-legacy Aug 25, 2018
Update matrix-sdk.aar lib - build 1875 - Revision: ccf12449b8f09b06a7a8f501b9d7a382270b2305

Last rebase was performed June 1 2018. Here is the list of changes from vector-im/riot-android changes:

Changes in Riot 0.8.XX (2018-08-24)
===================================================

Features:
 - Manage server quota notices (#2440)

Improvements:
 - Do not ask permission to write external storage at startup (#2483)
 - Update settings icon and transparent logo for notifications and navigation drawer (#2492)
 - URL previews are no longer requested from the server when displaying URL previews is disabled (PR #2514)
 - Fix some plural and puzzle strings, and remove other unused ones (#2444)
 - Manage System Alerts in a dedicated section

Other changes:
 - Upgrade olm-sdk.aar from version 2.2.2 to version 2.3.0
 - move PieFractionView from the SDK to the client (#2525)

Bugfix:
 - Fix media sharing (#2530)
 - Fix notification sound issue in settings (#2524)
 - Disable app icon badge for "listen for event" notification (#2104)

Changes in Riot 0.8.13 (2018-08-09)
===================================================

Features:
 - Resurrect performance metrics (#2391)
 - Telemetry to report incidence of UISIs (#2330)
 - Add a previewer for previewing media before sending it into the room (#1742|#2445)
 - Implements ReplyTo feature (#2390)
 - Add auto completion for slash commands (#2384)
 - Support Room Versioning (#2441)

Improvements:
 - Update matrix-sdk.aar lib (v0.9.7).
 - Piwik: Update the way how stats are reported (#2402)
 - Improve BugReport screen: display a preview of the screenshot (#2318)
 - In the settings, move theme settings just below "language" (#2439)
 - Improve the display of the sources of the message in the dialog (#2348)
 - Improve the display of the buttons and the reason in the room preview (#2352)
 - In the flair section on settings, notify the user when he has no flair (#2430)
 - Improve GDPR consent webview management (#2491)
 - Support external keyboard to send messages for recent devices (#220, #1279)
 - When user ignores or un-ignores someone, notify that the app will restart (#2437)

Other changes:
 - Remove dependency to `android-gif-drawable` lib and use Glide to animate logo on Splashscreen (#2421)
 - Keep only Room.getState() method and remove Room.getLiveState() because they are similar (matrix-org/matrix-android-sdk#310)

Bugfix:
 - Fix issue on incoming call screen when "Do not disturb mode" is active (#2417)
 - Fix issue when selecting sound for notifications in the settings
 - Fix issue when changing device name in the settings (#2416)
 - Fix issue on verifying device, update the wording of the description message (#1067)
 - Messages with code blocks show other HTML as plain text (#2280)
 - Message with <p> was sometimes not properly formatted (#2275)
 - Fix notification issue when Riot is not started (#2451)
 - Fix Unable to add Matrix apps (#2466)
 - Riot auto joined a public room (#2472)
 - Remove last traces of Firebase analytics (#2481)
 - code blocks are escaped and therefore hard readable (#2484)
 - Restore the navigation of the back button in the public rooms preview header (#2473)
 - Fix issue on preference screen: device lists was not displayed (#2409)
 - Ensure notification has a title (#2242)

Changes in Riot 0.8.12 (2018-07-06)
===================================================

Bugfix:
 - Fix issue on vanished favorite and low priority room (#2413)

Changes in Riot 0.8.11 (2018-07-03)
===================================================

Features:
 - Re-request keys manually for encrypted events (#2319)
 - Add option to send voice message to a room, using a third application to record message.
   To enable in the Labs settings (PR #1762)

Improvements:
 - Update matrix-sdk.aar lib (v0.9.6).
 - New Floating Action Menu in Home screen (PR #2335)
 - Add spacing to device keys (#2314)
 - use apply() instead of commit() to save shared prefs (#2231)
 - Do not ring if "Do Not Disturb" is active (#1072)
 - Manage the "consent not given" error when declining a room invite

Other changes:
 - Remove "Matrix application" activation from the Lab section in the settings (#2341)

Bugfix:
 - Remove black borders on 18:9 phone (#2063)
 - Auto dismiss the join/reject room notification when user select an action (#2354)
 - Fix some crashes reported by the PlayStore (#2380, #2382, #2383, #2395)
 - Fix issues in UrlPreviews (#2312)

Translations:
 - Galician thanks to Miguel Branco

Build:
 - Add script to check code quality
 - Travis will now check if CHANGES.rst has been modified for each PR

------

Merge commit '94b7925a57b800db62b5ec87966d994ff53392b4' into develop

# Conflicts:
#	vector/src/main/java/im/vector/activity/VectorRoomActivity.java
#	vector/src/main/java/im/vector/adapters/VectorMediasViewerAdapter.java
#	vector/src/main/java/im/vector/db/VectorContentProvider.java
#	vector/src/main/java/im/vector/dialogs/ConsentNotGivenHelper.kt
#	vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.kt
#	vector/src/main/res/values/strings.xml
#	vector/src/main/res/values/styles.xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants