Skip to content

Add get_media_upload_limits_for_user and on_media_upload_limit_exceeded callbacks to module API #18848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 12, 2025
Merged

Add get_media_upload_limits_for_user and on_media_upload_limit_exceeded callbacks to module API #18848

merged 22 commits into from
Sep 12, 2025

Conversation

hughns
Copy link
Member

@hughns hughns commented Aug 20, 2025 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@github-actions github-actions bot deployed to PR Documentation Preview August 20, 2025 10:47 Active
@github-actions github-actions bot deployed to PR Documentation Preview August 27, 2025 17:57 Active
@hughns hughns force-pushed the hughns/media-upload-limits-module-api branch from 6954400 to 768549f Compare August 27, 2025 17:58
@github-actions github-actions bot deployed to PR Documentation Preview August 27, 2025 17:59 Active
@github-actions github-actions bot deployed to PR Documentation Preview August 29, 2025 06:36 Active
@hughns hughns marked this pull request as ready for review August 29, 2025 07:20
@hughns hughns requested a review from a team as a code owner August 29, 2025 07:20
@hughns hughns force-pushed the hughns/media-upload-limits-module-api branch from 8734424 to 3ca9e05 Compare September 8, 2025 10:26
@github-actions github-actions bot deployed to PR Documentation Preview September 8, 2025 10:27 Active
@github-actions github-actions bot deployed to PR Documentation Preview September 8, 2025 10:40 Active
anoadragon453
anoadragon453 requested changes Sep 9, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! Just some minor doc and logic comments below.

Thanks for adding tests!

@hughns @anoadragon453
Apply suggestions from code review
1cb04a0 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2025 14:36 Active
@hughns @anoadragon453
Update tests/rest/client/test_media.py
9205e57 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2025 14:42 Active
@hughns @anoadragon453
Update synapse/media/media_repository.py
2636172 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2025 14:53 Active
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2025 15:04 Active
@hughns
Improve documentation
a751ef1 
Add python docs
Add references between docs
@hughns
Fix links
4f163e8
@hughns
Links again
2605584
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2025 15:45 Active
anoadragon453
anoadragon453 requested changes Sep 11, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some small things now.

@hughns @anoadragon453
Apply suggestions from code review
5e821e1 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@github-actions github-actions bot deployed to PR Documentation Preview September 12, 2025 09:47 Active
@github-actions github-actions bot deployed to PR Documentation Preview September 12, 2025 09:55 Active
@github-actions github-actions bot deployed to PR Documentation Preview September 12, 2025 10:52 Active
anoadragon453
anoadragon453 approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work collaborating and getting to the bottom of that mystery!

This now LGTM.

@anoadragon453 anoadragon453 enabled auto-merge (squash) September 12, 2025 11:21
@anoadragon453
Copy link
Member

Complement CI is failing due to a known flake.

Merging manually.

@anoadragon453 anoadragon453 merged commit e1036ff into develop Sep 12, 2025
46 of 48 checks passed
@anoadragon453 anoadragon453 deleted the hughns/media-upload-limits-module-api branch September 12, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
A-Media-Repository A-Modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughns @anoadragon453 @MadLittleMods