-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pagination) : add size
prop
#16858
Conversation
BREAKING CHANGE : size closed element-plus#16830
# Conflicts: # packages/components/pagination/src/pagination.ts
👋 @webvs2, seems like this is your first time contribution to element-plus.
|
🧪 Playground Preview: https://element-plus.run/?pr=16858 |
size
prop
I think it would also be good to add unified global setting size support to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use useFormSize to get size for el-pagination. |
The purpose of this function is to get the size of the previous level rather than just relying on the global, and the use is that if the size is set like 'from', it is actually good to use the local t mentioned above, right? |
useFormSize obtains size in the order of props, formItem, form, globalConfig |
It's weird. I used a new browser. You can see this link. https://preview-16858-element-plus.surge.sh/en-US/component/pagination.html#more-elements |
我也在线上链接复现了该问题,这确实奇怪,我在本地也运行了docs:dev,仍然没有本地复现,我将排查问题 |
@kooriookami That problem seems to have gone away |
Co-authored-by: kooriookami <38392315+kooriookami@users.noreply.github.com>
Oh, I just noticed this. |
Thanking Everyone ; |
为什么不顺便把 |
之前的改动丢失了这个特性,#17306 |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.close #16830