Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed various small bugs #215

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed various small bugs #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c8f55f
Fix: Octicons dependency should take care of the indirection in Octic…
jduthon Oct 4, 2017
b6525e1
Fix: FormInput uses right attribute for its input
jduthon Oct 4, 2017
6f2c4b9
Add build on postinstall so it works out from a git check out repo
jduthon Oct 16, 2017
33d2db2
Revert "Add build on postinstall so it works out from a git check out…
jduthon Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/FormIconField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ const classNames = require('classnames');
const FormField = require('./FormField');
const Spinner = require('./Spinner');

const ICON_MAP = require('../Octicons').map;
const ICON_KEYS = require('../Octicons').keys;
const Octicons = require('../Octicons').Octicon;
const ICON_MAP = Octicons.map;
const ICON_KEYS = Octicons.keys;
const COLOR_VARIANTS = ['danger', 'default', 'primary', 'success', 'warning'];

export default React.createClass({
Expand Down
2 changes: 1 addition & 1 deletion src/components/FormInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default React.createClass({
this.input.select();
},
getRef (ref) {
this.target = ref;
this.input = ref;

if (this.props.innerRef) {
this.props.innerRef(ref);
Expand Down
5 changes: 3 additions & 2 deletions src/components/Glyph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
var React = require('react');
var classNames = require('classnames');

var icons = require('../Octicons').map;
var validNames = require('../Octicons').keys;
const Octicons = require('../Octicons').Octicon;
const icons = Octicons.map;
const validNames = Octicons.keys;

var Glyph = React.createClass({
displayName: 'Glyph',
Expand Down