Bounding min value of expected range in volume anomalies to 0. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELE-1429 TTV - Fix freshness / volume anomalies on negative expected range
Definition of done:
|
|
👋 @elongl |
elongl
commented
Aug 28, 2023
macros/edr/data_monitoring/anomaly_detection/get_anomaly_scores_query.sql
Outdated
Show resolved
Hide resolved
haritamar
approved these changes
Aug 28, 2023
elongl
deleted the
ele-1429-ttv-fix-freshness-volume-anomalies-on-negative-expected
branch
ellakz
reviewed
Aug 28, 2023
|
|
||
| {% macro get_negative_value_supported_metrics() %} | ||
| {% do return(["min", "max", "average", "standard_deviation", "variance", "sum"]) %} |
There was a problem hiding this comment.
@elongl just to better understand- this will prevent negative row count from showing because count is not in this list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.