Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for environments other than dev and prod #1176

Closed
menzenski opened this issue Sep 26, 2023 · 4 comments · Fixed by #1373
Closed

Support for environments other than dev and prod #1176

menzenski opened this issue Sep 26, 2023 · 4 comments · Fixed by #1373

Comments

@menzenski
Copy link

Is your feature request related to a problem? Please describe.
We have six environments. One is named dev and one is named prod but there are four others. It's not ideal to be limited to dev and prod only. Two of our environments are "production" and we'd like to have them distinguished within elementary.

Describe the solution you'd like
Ideally we would be able to provide the name of our environment as a string, so that we are not limited to the two provided environment names.

Describe alternatives you've considered

Additional context

Would you be willing to contribute this feature?
Yes, happy to make an attempt. Might need some direction.

@leonardo-melo
Copy link

We would also love this feature, as @menzenski organization, we also have a bunch of environments in different regions we would like to differentiate in the dashboard. We also would be willing to help make it happen.

@noaKurman
Copy link
Contributor

Hey @menzenski !
Would love to help you get started on it
Our final goal is to get the env name from the env mentioned in the invocations table (We assume we have the env and project names already saved in our tables, so to make it more efficient we want to automatically receive it from there)
BUT as we understand this is a bit more complicated and this feature is required by a lot of users we can start from a very simple "step 1" solution - which would just be removing the Choice from the CLI (if you look at the file containing all the flags you'll see env is only getting a choice between dev and prod, we can turn it into a string for free text)

Is that clear? Do you need me to give you more details about which files we're talking about and what are the steps for this change?

@leonardo-melo
Copy link

For us the second option ("step 1"), would be more than enough, to just pass our desired string to the cli option.

@willbowditch
Copy link
Contributor

I've opened a PR for this here: #1373

haritamar added a commit that referenced this issue May 28, 2024
Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants