remove test subtype from most alerts #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ellakz |
| @@ -152,22 +152,28 @@ def data(self) -> Dict: | |||
|
|
|||
| @property | |||
| def concise_name(self) -> str: | |||
| if self.is_elementary_test: | |||
| if self.test_sub_type_display_name.lower() not in ( | |||
There was a problem hiding this comment.
concise_name is used on the group_by method both in Slack and Teams.
Make sure that this change is not breaking anything 🙏🏻
There was a problem hiding this comment.
yeah I want to remove this unnecessary thing in the group alerts too
ellakz
force-pushed
the
ele-2908-remove-test-subtype-from-alerts
branch
from
f023f10
to
b64e7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.