Throw a dialog on failure when trying to open an installed app #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cassidyjames I was not able to reproduce the error you described in #1494: Screen.record.from.2021-02-27.09.11.39.mp4When I click open, Glimpse is opened in the background. Could you please test this branch and share the error message you get. |
|
So of course I can't reproduce this now… but it looks to me like a dialog would be good in case of future failures, as it could help us track it down. |
danirabbit
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1456 we added support to throw a toast when an app is installed.
Sometimes opening the application fails. For now this adds a dialog showing an error message.
Fixes #1494