-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to switch cameras #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thank you for working on this feature. This looks really great! I left a few inline comments to clean things up a bit.
One big thing I noticed is that it seems you included a workaround for menuitem labels that shouldn't be necessary with the latest revision of the stylesheet in Odin. So that should save quite a lot of code to not apply this
I think one thing to consider is that we should probably only show the menu button if there is actually more than 1 camera available. It would probably look nice to put this in a Gtk.Revealer with a slide transition
@danrabbit @cassidyjames Thank you for the kind reviews. I'll work on them on the next days. After cleaning up I'll try implementing your suggestion regarding revealing the menu only when more than one camera exists. |
@danrabbit I added some animations with the |
I have removed the commented section and feel this should be ready for another review. |
@igordsm can you resolve conflicts between this branch and master? |
Co-authored-by: Daniel Foré <daniel@elementary.io>
2206693
to
06eb83a
Compare
@danrabbit Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX-wise this is super close for me! Would it be possible to add a RadioButton to the start of the menu items to show which camera is chosen?
@cassidyjames Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great for me. Awesome work!
This PR closes #41 and closes #59 . It adds a dropdown menu with possible cameras and switches to newly plugged ones on the fly. If more than one camera is present the last one provided by
Gst.DeviceMonitor
is used.