Basic keyboard quarter tiling #408

peteruithoven · 2018-11-10T01:12:32Z

Basic quarter tiling support.
Ctrl + Super + 1: Tile top left
Ctrl + Super + 2: Tile top right
Ctrl + Super + 3: Tile bottom left
Ctrl + Super + 4: Tile bottom right

Partially Implements: #105 (only the keyboard support).

To my surprise, contrary to when using wmctrl, there was no issue with different shadows margins.

It doesn't transition (yet).

cassidyjames · 2018-11-10T19:09:04Z

I think we'd want these to be bound to arrow keys by default if possible, so:

Ctrl+Super+Up+Left, Ctrl+Super+Up+Right, etc.

peteruithoven · 2018-11-10T20:23:52Z

Good point.
I'm having a bit of an issue with the keybindings though.
With the keybindings:

<Super><Ctrl><Up>Left
<Super><Ctrl><Up>Right
<Super><Ctrl><Bottom>Left
<Super><Ctrl><Bottom>Right

only the bottom left + right work. It also blocks regular left and right tile.

With the keybindings:

<Super><Ctrl><Left>Up
<Super><Ctrl><Right>Up
<Super><Ctrl><Left>Bottom
<Super><Ctrl><Right>Bottom

both Super+Ctrl+left and Super+Ctrl+left +Up and Super+Ctrl+left +Down triggers tiles top left.
both Super+Ctrl+right and Super+Ctrl+right +Up and Super+Ctrl+right +Down triggers tile right.

Anyway, quite a mess. I could use some tips on how to get this working.

jchannon · 2018-11-10T21:36:10Z

I’d prefer these but not sure it fixes your issue.

Move to the upper left — ⌃⌘←
Move to the lower left — ⌃⇧⌘←
Move to the upper right — ⌃⌘→
Move to the lower right — ⌃⇧⌘→

⌘ = super
⌃ = ctrl ?
⇧ = shift ?

Command-Control-Shift-

peteruithoven · 2018-11-11T16:58:07Z

@jchannon I might be confused by your usage of ⌃ (which means ctrl right?), but isn't ⌃⌘←( Ctrl+Super+←) the same as the current tile left keyboard shortcut?

jchannon · 2018-11-11T17:05:20Z

Quite possibly, those are the shortcuts I use on OSX for quarter tiling :)

ianmjones · 2018-11-12T10:49:26Z

This is awesome, but I worry that changing the key combinations to use two cursor keys at the same time would be problematic given that using one of those keys is already ingrained and as @peteruithoven has found requires some special handling of the keybindings.

I would propose something a little more visual and hopefully simpler to implement.

Ctrl+Super+u: Top Left
Ctrl+Super+i: Top Right
Ctrl+Super+j: Bottom Left
Ctrl+Super+k: Bottom Right

This could later be suplemented with 3rd tiling...

Ctrl+Super+d: Left 3rd
Ctrl+Super+f: Middle 3rd
Ctrl+Super+g: Right 3rd

Ctrl+Super+e: Left 2 3rds
Ctrl+Super+t: Right 3rds

I might be influenced by muscle memory, but I do honestly think it's less problematic.

peteruithoven · 2018-11-12T16:13:40Z

One issue with using letters is that it's logical orientation breaks down on non Querty keyboards. I couldn't find statistics on keyboard layout popularity.

ianmjones · 2018-11-12T20:50:52Z

Hmm, yeah, that did occur to me.

I wonder if there is some sort of hardware code mapping that could be used more reliably than letters for saving to settings?

jchannon · 2019-01-30T10:52:16Z

Any update to this, most distros have quarter tiling so it would be good to get it into elementary

peteruithoven · 2019-02-07T19:18:33Z

plugins/quartertiler/Main.vala

-			if (!("tile-topleft" in settings.list_keys ())) {
-					warning ("Quarter tiling key bindings not found");
-					return;
-			}


@ricotz Thanks for the cleanup! But why remove this check? Without this, if a user where to try gala with this version and then downgrade he wouldn't be able to login anymore.
See: https://elementaryos.stackexchange.com/a/17582/3892

gsettings schemas and keys are part of the API. We can't deal with not properly installed systems of all kinds.

After I've experiencing suddenly not being able to login that seems scary / fragile, but yeah it probably doesn't make sense to make an exception for this property.

thomasfaller · 2019-02-10T13:52:52Z

Would be a terrific addition!

Julioevm · 2019-02-22T11:34:38Z

I hope this get added soon, its really useful productivity wise!

donadigo

Is it intentional that you cannot tile a window that's already fully maximized? I would expect that to work.

…screen windows

peteruithoven · 2019-07-03T00:24:17Z

@donadigo nop it definitely wasn't. I just rarely use maximized / fullscreen windows. I added those allow resize / move checks because that seemed safe. But I changed it, it now also works for maximized and fullscreen windows.

donadigo

Looks good to me.

peteruithoven · 2019-07-10T16:14:40Z

So a little summarizing update, beside tiling using Super+Ctrl+1/2/3/4 I've implemented @btkostner's suggestion. You can now quarter tile using a two step process:

Tile window to left or right using Super+Ctrl+Left/Right
Quarter tile window to top or bottom of that side using Super+Ctrl+Up/Down

Tiling to top or bottom half is also supported:

Maximize window using Super+Up
Tile to top or bottom half using: Super+Ctrl+Up/Down

And thanks @jlnr for the code review.

jlnr · 2019-07-10T16:24:16Z

Can't wait to try the updated branch 💪

Another thought: Does a majority of people use keyboards with numpads? (Definitely not me, I'm a complete TKL fanatic 😬) Would 1, 3, 6, 9 be more intuitive shortcuts for corner tiling in that case? You could also use 4 and 6 for half-screen tiling, etc...

btkostner · 2019-07-10T16:27:33Z

@jlnr @cassidyjames That's a pretty cool idea. I would wonder how many people use a 10 key with elementary. I personally do, and this solution sounds like the best for me, but I'm not sure that would work for everyone...

peteruithoven · 2019-07-10T18:11:29Z

I've personally never had those, on any of the laptops I've owned. But sounds like someone could just remap the Super+Ctrl+1/2/3/4 and Super+Ctrl+Left shortcuts?
You might miss something for the 2 and 8 though, something to directly tile something to the top or bottom half of the screen.

It's a pity it's not possible to bind multiple keyboard shortcuts to the same action, as far as I know.

plugins/quartertiler/Main.vala

renevall · 2019-08-21T21:09:49Z

I hope this makes it. I'm actually using a UHD 3440x1440 and three panels side by side would be awesome too. But yes, hope all the work on this ticket makes it

Thanks for resolving this.

jlnr · 2019-10-02T21:56:11Z

@btkostner About the numpad idea: Turns out Ubuntu MATE 19.10 just changed it's tiling shortcuts away from a numpad-based system (see "New Key-bindings"). I don't know what data they've based it on, but it seems numpads are not an overwhelming majority then.

jlnr

The code is fine and does the job, but due to the technical limitations mentioned above, using the arrow keys feels a bit like a hack: cmd+ctrl+left+up only works if you press "left" before "up", etc.

Also, if you press cmd+ctrl+left, cmd+ctrl+down, cmd+ctrl+right, cmd+ctrl+down, you can see a ghost window floating in the wrong direction. I am not sure if this can be fixed easily.

I think it's up to @elementary/ux to decide whether this is polished enough. In any case, the number-based shortcuts feel solid.

jchannon · 2019-11-27T10:05:17Z

How is this still not merged 😄 Looking at the issue list there is 10 issues about tiling. Do elementary not think tiling is important?

jlnr · 2019-11-28T07:50:28Z

Because it's important to get it right - that's why there are several issues and even alternative PRs (#595). The underlying APIs are also a bit limited (keyboard shortcuts, mutter tiling). The best way to accelerate this is to provide a PR that has absolutely no glitches 😜

gazsp · 2019-12-13T21:54:11Z

Please get this added!

It's one of the main things I miss from macOS / SizeUp - not being able to fling windows around with super + numpad (quartered / halved / centred)

Just make the keys re-definable in Keyboard Settings to keep everyone happy.

jchannon · 2020-02-07T19:39:08Z

Anyone tried this? https://www.linuxuprising.com/2020/02/wintile-for-gnome-shell-windows-10-like.html

jeremypw · 2021-04-29T11:38:24Z

@peteruithoven Converting to draft as there are conflicts and unresolved design issues, however there seems to be a lot of interest in it.
@danrabbit Is it just choice of shortcuts blocking this? Can the design issues be resolved or is there a fundamental conflict?

peteruithoven · 2021-05-08T10:27:15Z

Makes sense. I'd be down to update if there is at least a decent change this will be merged.

spotlesscoder · 2023-02-18T20:19:45Z

For me, the initially proposed key combinations would make the most sense:

Ctrl + Super + 1: Tile top left
Ctrl + Super + 2: Tile top right
Ctrl + Super + 3: Tile bottom left
Ctrl + Super + 4: Tile bottom right

Are there any plans to implement such a feature?
I've seen multiple PRs in this repo which also provide very cool methods for organizing windows withing a single display.

Would be nice of one of these would be discussed with the design team and eventually make it into a future release of gala.

So far, these approaches seem the most promising:

#595
#890

peteruithoven mentioned this pull request Nov 10, 2018

Quarter/corner tiling #105

Open

peteruithoven mentioned this pull request Dec 18, 2018

Missing keys in settings schema causing login loop #431

Closed

ricotz force-pushed the quarter-tiler branch from 8c9bbed to 5540331 Compare February 7, 2019 18:38

peteruithoven commented Feb 7, 2019

View reviewed changes

peteruithoven changed the title ~~Basic quarter tiling~~ Basic keyboard quarter tiling Feb 11, 2019

peteruithoven and others added 5 commits February 27, 2019 17:57

Basic quarter tiling

4031307

unmaximize before tiling

f580618

Cleanup & style fixes

f414659

Check existence gsettings

1de2e3c

Clean up

e1ebfe3

ricotz force-pushed the quarter-tiler branch from cfd8af0 to e1ebfe3 Compare February 27, 2019 16:58

donadigo added 2 commits May 24, 2019 15:21

Merge branch 'master' into quarter-tiler

1a5d881

Merge branch 'master' into quarter-tiler

d0723a2

donadigo suggested changes Jul 2, 2019

View reviewed changes

peteruithoven added 2 commits July 3, 2019 02:21

Remove allow resize and move check enabling tiling maximized and full…

c104574

…screen windows

Un-fullscreen fullscreen apps before tiling

2840bb6

donadigo previously approved these changes Jul 3, 2019

View reviewed changes

cassidyjames added the Needs Design Waiting for input from the UX team label Jul 3, 2019

jlnr previously requested changes Jul 14, 2019

View reviewed changes

plugins/quartertiler/Main.vala Outdated Show resolved Hide resolved

peteruithoven added 2 commits July 14, 2019 13:13

Removed unused variable

2638129

Merge branch 'master' into quarter-tiler

589aadf

cassidyjames and others added 2 commits August 29, 2019 11:41

Merge branch 'master' into quarter-tiler

2833134

Merge branch 'master' into quarter-tiler

bafa624

kgrubb requested a review from jlnr September 18, 2019 18:12

Merge branch 'master' into quarter-tiler

8c3c1f5

jlnr reviewed Oct 2, 2019

View reviewed changes

Merge branch 'master' into quarter-tiler

1d4efc8

Merge branch 'master' into quarter-tiler

832675d

Merge branch 'master' into quarter-tiler

989836f

cassidyjames and others added 2 commits December 17, 2019 14:59

Merge branch 'master' into quarter-tiler

c635a7c

Merge branch 'master' into quarter-tiler

b83a2d9

Julioevm mentioned this pull request Aug 31, 2020

Auto-tiling feature like in Pop_OS! #870

Closed

jeremypw added the Conflicts label Apr 29, 2021

jeremypw marked this pull request as draft April 29, 2021 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic keyboard quarter tiling #408

Basic keyboard quarter tiling #408

peteruithoven commented Nov 10, 2018 •

edited

Loading

cassidyjames commented Nov 10, 2018

peteruithoven commented Nov 10, 2018 •

edited

Loading

jchannon commented Nov 10, 2018 •

edited by peteruithoven

Loading

peteruithoven commented Nov 11, 2018

jchannon commented Nov 11, 2018

ianmjones commented Nov 12, 2018

peteruithoven commented Nov 12, 2018

ianmjones commented Nov 12, 2018

jchannon commented Jan 30, 2019

peteruithoven Feb 7, 2019

ricotz Feb 7, 2019

peteruithoven Feb 8, 2019

thomasfaller commented Feb 10, 2019

Julioevm commented Feb 22, 2019

donadigo left a comment

peteruithoven commented Jul 3, 2019

donadigo left a comment

peteruithoven commented Jul 10, 2019 •

edited

Loading

jlnr commented Jul 10, 2019

btkostner commented Jul 10, 2019

peteruithoven commented Jul 10, 2019 •

edited

Loading

renevall commented Aug 21, 2019 •

edited

Loading

jlnr commented Oct 2, 2019

jlnr left a comment

jchannon commented Nov 27, 2019

jlnr commented Nov 28, 2019

gazsp commented Dec 13, 2019

jchannon commented Feb 7, 2020

jeremypw commented Apr 29, 2021

peteruithoven commented May 8, 2021

spotlesscoder commented Feb 18, 2023

Basic keyboard quarter tiling #408

Are you sure you want to change the base?

Basic keyboard quarter tiling #408

Conversation

peteruithoven commented Nov 10, 2018 • edited Loading

cassidyjames commented Nov 10, 2018

peteruithoven commented Nov 10, 2018 • edited Loading

jchannon commented Nov 10, 2018 • edited by peteruithoven Loading

peteruithoven commented Nov 11, 2018

jchannon commented Nov 11, 2018

ianmjones commented Nov 12, 2018

peteruithoven commented Nov 12, 2018

ianmjones commented Nov 12, 2018

jchannon commented Jan 30, 2019

peteruithoven Feb 7, 2019

Choose a reason for hiding this comment

ricotz Feb 7, 2019

Choose a reason for hiding this comment

peteruithoven Feb 8, 2019

Choose a reason for hiding this comment

thomasfaller commented Feb 10, 2019

Julioevm commented Feb 22, 2019

donadigo left a comment

Choose a reason for hiding this comment

peteruithoven commented Jul 3, 2019

donadigo left a comment

Choose a reason for hiding this comment

peteruithoven commented Jul 10, 2019 • edited Loading

jlnr commented Jul 10, 2019

btkostner commented Jul 10, 2019

peteruithoven commented Jul 10, 2019 • edited Loading

renevall commented Aug 21, 2019 • edited Loading

jlnr commented Oct 2, 2019

jlnr left a comment

Choose a reason for hiding this comment

jchannon commented Nov 27, 2019

jlnr commented Nov 28, 2019

gazsp commented Dec 13, 2019

jchannon commented Feb 7, 2020

jeremypw commented Apr 29, 2021

peteruithoven commented May 8, 2021

spotlesscoder commented Feb 18, 2023

peteruithoven commented Nov 10, 2018 •

edited

Loading

peteruithoven commented Nov 10, 2018 •

edited

Loading

jchannon commented Nov 10, 2018 •

edited by peteruithoven

Loading

peteruithoven commented Jul 10, 2019 •

edited

Loading

peteruithoven commented Jul 10, 2019 •

edited

Loading

renevall commented Aug 21, 2019 •

edited

Loading