Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: Remove Granite.CloseButtonPosition #568

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

danirabbit
Copy link
Member

This appears to be used only once in Gala

@danirabbit danirabbit added the Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Jan 13, 2022
@danirabbit danirabbit requested a review from a team January 13, 2022 19:12
Copy link
Member

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@danirabbit danirabbit merged commit bc3d035 into main Jan 14, 2022
@danirabbit danirabbit deleted the utils-removeclosebuttonposition branch January 14, 2022 17:27
JoseExposito added a commit to elementary/gala that referenced this pull request Jan 14, 2022
The API Granite.CloseButtonPosition has been deprecated [1].

Remove it from Gala and always place the close button on the left of
the window in the multitasking view.

[1] elementary/granite#568
@JoseExposito
Copy link
Member

Removed from Gala:
elementary/gala#1364

JoseExposito added a commit to elementary/gala that referenced this pull request Jan 22, 2022
The API Granite.CloseButtonPosition has been deprecated [1].

Remove it from Gala and use Mutter's API to get the close button
position.

[1] elementary/granite#568
tintou pushed a commit to elementary/gala that referenced this pull request Jan 23, 2022
The API Granite.CloseButtonPosition has been deprecated [1].

Remove it from Gala and use Mutter's API to get the close button
position.

[1] elementary/granite#568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants