Open attachment dialog fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintou
reviewed
Jul 18, 2017
src/MessageList/AttachmentBar.vala
Outdated
| @@ -69,8 +69,8 @@ public class Mail.AttachmentBar : Gtk.FlowBox { | |||
| } | |||
|
|
|||
| private void show_attachment (Camel.MimePart attachment_part) { | |||
| var dialog = new Mail.AttachmentDialog (attachment_part); | |||
| dialog.transient_for = get_toplevel () as Gtk.Window; | |||
| var dialog = new Mail.OpenAttachmentDialog ((Gtk.Window) get_toplevel (), attachment_part); | |||
There was a problem hiding this comment.
Here the as keyword is important, if it's not a Gtk.Window we don't want to use it.
|
don't forget to change the file name in po/POTFILES |
tintou
reviewed
Jul 18, 2017
| } | ||
|
|
||
| private async void show_file_anyway () { | ||
| try { | ||
| GLib.FileIOStream iostream; | ||
| var file = File.new_tmp ("XXXXXX-%s".printf (mime_part.get_filename ()), out iostream); | ||
| yield mime_part.content.decode_to_output_stream (iostream.output_stream, GLib.Priority.DEFAULT, null); | ||
| yield GLib.AppInfo.launch_default_for_uri_async (file.get_uri (), null, null); | ||
| yield GLib.AppInfo.launch_default_for_uri_async (file.get_uri (), new AppLaunchContext (), null); |
There was a problem hiding this comment.
The binding here is misleading, it's nullable so If you want to avoid the compilation warning, better do (GLib.AppLaunchContext) null
Reference: https://developer.gnome.org/gio/stable/GAppInfo.html#g-app-info-launch-default-for-uri-async
tintou
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialogsas in other elementary apps