Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: First time you click a link it scrolls to the top #9

Closed
wants to merge 2 commits into from
Closed

Fixed: First time you click a link it scrolls to the top #9

wants to merge 2 commits into from

Conversation

Philip-Scott
Copy link
Member

Fixes: #6

@Djaler
Copy link
Contributor

Djaler commented Apr 24, 2017

This fix has a regression: now I can't copy text from message by Ctrl+C

@Djaler
Copy link
Contributor

Djaler commented Apr 24, 2017

You should find a way to keep StylishWebView focusable, but prevent scrolling

@Philip-Scott
Copy link
Member Author

ahh shit, it was too good to be true. Good catch!

danirabbit
danirabbit requested changes Apr 25, 2017
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying djaler's comment as a review:

This fix has a regression: now I can't copy text from message by Ctrl+C

@codygarver codygarver added the Status: Blocked Something else needs to be done before this can be fixed label May 2, 2017
@tintou tintou deleted the fixed-click-on-link-scrolling-to-top branch June 15, 2017 21:31
@casasfernando casasfernando mentioned this pull request Aug 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit requested changes

Assignees
No one assigned
Labels
Status: Blocked Something else needs to be done before this can be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Philip-Scott @Djaler @danirabbit @codygarver