Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make collapsed cards more compact #97

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Make collapsed cards more compact #97

merged 2 commits into from
Jul 22, 2017

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 21, 2017

Not sure if this should be merged, but putting this here for visibility. Probably needs to be played with for a while to see how it feels in practice. Looks like:

screenshot from 2017-07-20 13 10 30

@danirabbit danirabbit added Needs Design Waiting for input from the UX team Rewrite labels Jul 21, 2017
@cassidyjames
Copy link
Contributor

I really like how this looks. I think we can try it out and see how it feels. I like that it keeps the from, timestamp, and favorite status all visible (and vertically centered) while saving some space and also overlapping the avatar, which helps imply there's more content to be revealed.

👍

@tintou
Copy link
Member

tintou commented Jul 22, 2017

I like it 👍

Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Let's give it a go!

@davidmhewitt davidmhewitt merged commit 8544443 into rewrite Jul 22, 2017
@davidmhewitt davidmhewitt deleted the compact-cards branch July 22, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants