Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music file[s] from within app #766

Merged
merged 9 commits into from
May 14, 2024
Merged

Add music file[s] from within app #766

merged 9 commits into from
May 14, 2024

Conversation

jeremypw
Copy link
Collaborator

Towards a fix of #716

  • Adds an actionbar/button linked to an open file[s] action.
  • Open file[s] action shows a filechooser dialog for selecting multiple files
  • Selected files are added to the playlist.

This PR does not implement the open folder element of the issue as that would require a separate action/button. That can be simply added later if this PR is accepted.

@jeremypw jeremypw requested a review from a team December 14, 2023 18:59
@jeremypw jeremypw changed the title Add music file from within app Add music file[s] from within app Dec 14, 2023
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, just some nitpicking comments.

src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit enabled auto-merge (squash) May 14, 2024 17:45
@danirabbit danirabbit merged commit 7ebb2bf into main May 14, 2024
3 checks passed
@danirabbit danirabbit deleted the add-file branch May 14, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants