Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GObject-construct PhotoCanvas #686

Merged
merged 3 commits into from
Dec 1, 2021
Merged

GObject-construct PhotoCanvas #686

merged 3 commits into from
Dec 1, 2021

Conversation

treppenwitz03
Copy link
Contributor

GObject-construct PhotoCanvas.vala, the last one inside src/editing_tools. Also fixed some code style conflicts.

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicking comments.

src/editing_tools/PhotoCanvas.vala Outdated Show resolved Hide resolved
src/editing_tools/PhotoCanvas.vala Outdated Show resolved Hide resolved
treppenwitz03 and others added 2 commits December 1, 2021 15:44
Co-authored-by: Ryo Nakano <26003928+ryonakano@users.noreply.github.com>
Co-authored-by: Ryo Nakano <26003928+ryonakano@users.noreply.github.com>
@treppenwitz03
Copy link
Contributor Author

Understood well. Thanks!

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@treppenwitz03
Copy link
Contributor Author

Thanks again @ryonakano !

@ryonakano ryonakano merged commit 67d58a3 into elementary:master Dec 1, 2021
@treppenwitz03 treppenwitz03 deleted the gobject_construct_photocanvas branch December 1, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants