Fixed: Duplicated bluetooth devices #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donadigo
requested changes
May 18, 2017
src/Services/Manager.vala
Outdated
| private void add_device (BluetoothIndicator.Services.Device device, string path) { | ||
| lock (devices) { | ||
| if (!devices.has_key (path)) { | ||
| devices.set (path, device); |
There was a problem hiding this comment.
Use this:
devices[path] = device
src/Widgets/Views/MainView.vala
Outdated
| if (child is Bluetooth.Widgets.Device) { | ||
| ((Bluetooth.Widgets.Device) child).destroy (); | ||
| var device_child = child as Bluetooth.Widgets.Device; | ||
| if (device_child != null && device_child.device.modalias == device.modalias) { |
There was a problem hiding this comment.
Again, could we have a compare method inside the Device class like that?
public bool compare (Device device) {
return modalias == device.modalias;
}
It would just make this easier to compare devices in the future.
donadigo
approved these changes
May 18, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10 Makes sure to only add and send the signal that a device has been added once, also prevents all devices from being deleted if you unpair a device