Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add watching on markdown #922

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

fpasquet
Copy link
Contributor

@fpasquet fpasquet commented Apr 14, 2023

  • add watching on markdown and remove libraries for markdown in JS files for the client
  • update design system (add skeleton to search page)

@fpasquet fpasquet self-assigned this Apr 14, 2023
@fpasquet fpasquet added the WIP label Apr 14, 2023
@fpasquet fpasquet force-pushed the feat/add-watching-on-markdown branch 2 times, most recently from d0880c4 to 84e86eb Compare April 14, 2023 11:31
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 14, 2023 11:34 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/add-watching-on-markdown/ 🟠 68 🟢 97 🟢 92 🟢 92 🟠 70
/feat/add-watching-on-markdown/fr/authors/ajacquemin/ 🟠 71 🟢 97 🟢 92 🟢 92 🟠 70
/feat/add-watching-on-markdown/fr/comment-construire-site-web-avec-nextjs/ 🟠 83 🟢 97 🟢 92 🟢 100 🟠 70
/feat/add-watching-on-markdown/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 84 🟢 97 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/feat/add-watching-on-markdown/ 🔴 2379 🔴 7206 🟢 2379 🔴 7345 🟢 22 🟢 0
/feat/add-watching-on-markdown/fr/authors/ajacquemin/ 🟢 1717 🔴 6762 🟢 2102 🔴 6775 🟢 16 🟢 0
/feat/add-watching-on-markdown/fr/comment-construire-site-web-avec-nextjs/ 🔴 2391 🔴 3260 🟢 2623 🔴 8946 🟢 21 🟢 0
/feat/add-watching-on-markdown/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2164 🔴 3182 🟢 2315 🔴 7573 🟢 21 🔴 0.11

@fpasquet fpasquet force-pushed the feat/add-watching-on-markdown branch from 84e86eb to 854e7ff Compare April 14, 2023 12:15
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 14, 2023 12:18 Destroyed
@fpasquet fpasquet added mergeable status/reviewable status: reviewable and removed WIP labels Apr 14, 2023
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 18, 2023 08:58 Destroyed
@fpasquet fpasquet added WIP and removed mergeable status/reviewable status: reviewable labels Apr 18, 2023
@fpasquet fpasquet force-pushed the feat/add-watching-on-markdown branch from 696892d to 17f0692 Compare April 18, 2023 12:38
@fpasquet fpasquet changed the base branch from master to feat/add-unit-tests April 18, 2023 12:38
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 18, 2023 12:40 Destroyed
Base automatically changed from feat/add-unit-tests to master April 18, 2023 14:36
@fpasquet fpasquet requested a review from Pouzor April 18, 2023 15:40
@fpasquet fpasquet force-pushed the feat/add-watching-on-markdown branch from 17f0692 to 29ac8b9 Compare April 18, 2023 15:41
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 18, 2023 15:43 Destroyed
@fpasquet fpasquet force-pushed the feat/add-watching-on-markdown branch from 29ac8b9 to f90492d Compare April 21, 2023 06:33
@github-actions github-actions bot temporarily deployed to dev-feat/add-watching-on-markdown April 21, 2023 06:36 Destroyed
@fpasquet fpasquet merged commit 19c384c into master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/mergeable status: mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants