Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially underflow due to mal-aligned binary #16

Open
strazzere opened this issue Mar 4, 2020 · 0 comments
Open

Potentially underflow due to mal-aligned binary #16

strazzere opened this issue Mar 4, 2020 · 0 comments

Comments

@strazzere
Copy link
Contributor

Found via fuzzing;

https://github.com/elfmaster/libelfmaster/blob/85e949c51b219594c0b3f4014cb09037f1442996/src/inte
rnal.c#L1329

This check will cause a malformed object to perform a (0 - 0) - 6 which will cause a very large number to be compared against i. Resulting in crashes often when ins[i] is used by the memcmp -- there needs to be a check to prevent this, likely returning 0.

Unsure if this needs to throw / catch extra issues downstream?

strazzere added a commit to strazzere/libelfmaster that referenced this issue Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant