Bugfix #13 shift click not working #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the problem was with the menu swapper looking at the current item id in the clicked item. Since we change the item id to display the future item, the plugin miscalculated what to do somehow. The fix is to to the equipping at the end of the frame to allow menu swapper to behave correctly.
elgbar
changed the title
|
Closes #13 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the problem was with the menu swapper looking at the current item id in the clicked item. Since we change the item id to display the future item, the plugin miscalculated what to do somehow.
The fix is to the equipping at the end of the frame to allow menu swapper to behave correctly.