Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][FEATURE] Upgrade to TYPO3 v12 #285

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Conversation

eliashaeussler
Copy link
Owner

@eliashaeussler eliashaeussler commented Jun 12, 2023

This PR adds support for TYPO3 v12. Support for TYPO3 v10 and v11 has been dropped.

In addition, the following improvements were made:

  • Upgrade to 2.x of eliashaeussler/cache-warmup
  • Rewrite + finalize crawlers
  • Convert toolbar dropdown to modal
  • Introduce PageTypeProvider
  • Support exclusion patterns and crawling strategies
  • Support formatters on CLI
  • Improve event-handling of EventSource requests
  • Migrate from RequireJS to ESM
  • Migrate Frontend to rollup.js
  • Migrate custom elements to lit-html
  • Increase test coverage
  • Write acceptance tests

... and many more changes (see README.md for all changes).

@eliashaeussler eliashaeussler added enhancement New feature or request breaking This introduces a breaking change labels Jun 12, 2023
@eliashaeussler eliashaeussler self-assigned this Jun 12, 2023
@eliashaeussler eliashaeussler force-pushed the feature/typo3-v12 branch 5 times, most recently from f5fbb6e to fed9e2f Compare June 13, 2023 06:56
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17428 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit 8772ad4 and detected 21 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 7
Duplication 14

The test coverage on the diff in this pull request is 71.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 72.8% (51.3% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 71.87% and project coverage change: +51.27 🎉

Comparison is base (1b4d609) 21.52% compared to head (e1f28cf) 72.80%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #285       +/-   ##
=============================================
+ Coverage     21.52%   72.80%   +51.27%     
- Complexity      296      333       +37     
=============================================
  Files            27       41       +14     
  Lines           920     1114      +194     
=============================================
+ Hits            198      811      +613     
+ Misses          722      303      -419     
Impacted Files Coverage Δ
.../ContextMenu/ItemProviders/CacheWarmupProvider.php 0.00% <0.00%> (ø)
...es/Backend/ToolbarItems/CacheWarmupToolbarItem.php 0.00% <0.00%> (ø)
Classes/Controller/CacheWarmupController.php 0.00% <0.00%> (ø)
Classes/Controller/CacheWarmupLegacyController.php 0.00% <0.00%> (ø)
Classes/Controller/FetchSitesController.php 0.00% <0.00%> (ø)
Classes/Exception/MissingPageIdException.php 100.00% <ø> (ø)
...es/Exception/UnsupportedConfigurationException.php 100.00% <ø> (ø)
Classes/Utility/BackendUtility.php 0.00% <0.00%> (ø)
Classes/ValueObject/Modal/SiteGroup.php 0.00% <0.00%> (ø)
Classes/ValueObject/Modal/SiteGroupItem.php 0.00% <0.00%> (ø)
... and 31 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17435 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17442 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17506 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17525 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17523 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17524 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17522 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 18426 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 18474 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 19811 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 20154 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 20634 lines exceeds the maximum allowed for the inline comments feature.

@eliashaeussler eliashaeussler marked this pull request as ready for review July 4, 2023 20:43
@eliashaeussler eliashaeussler merged commit fd6e188 into main Jul 4, 2023
@eliashaeussler eliashaeussler deleted the feature/typo3-v12 branch July 4, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This introduces a breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant