Remove integer digit separator from preprocessor macro. Fix build with Clang #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of the integer thousands separator ' in preprocessor integrals results in build errors with Clang. (tested with clang versions 17,18 and 19).
|
This is extremely silly. Merged in 7da4041 with clang-format applied, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves this issue
This commit reverts the definition of SCN_COMPILER in pp_detect.h to what it was before commit 1c3280e
Direct link to file change reverted: include/scn/detail/pp_detect.h
The usage of the single-quote character as integer digit separator in preprocessor, results in build errors with Clang. (tested with clang versions 17,18 and 19). This probably happens because the preprocessor doesn't interpret the definition as an integer.
The error is generated by the dependency scanner.
Another proposal:
Instead of reverting, another option to increase readability would be to use binary power, instead of base 10, for the version number, although the result would be different.
Example:
( ((major) << 32) + ((minor) << 16) + (patch) )