Beautify Node.show() for parse tree printing #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
requested changes
Sep 4, 2023
|
My mistake. Change has now been made in the _ast_gen.py file. |
|
Tests are failing |
eliben
requested changes
Sep 6, 2023
pycparser/c_ast.py
Outdated
|
|
||
| children = self.children() | ||
| if len(children) > 0: | ||
| _, lastChild = children[-1] |
There was a problem hiding this comment.
I think you should be able to accomplish this in a cleaner way using enumerate in the for loop below. Then you can trivially find if the index is the one before last and you won't need this condition and lastChild
There was a problem hiding this comment.
I think I understood what you meant but if not let me know. Its been changed now.
eliben
requested changes
Sep 9, 2023
|
Added some more minor comments; also - all the tests fail on CI, please fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just indents, use an actual tree structure for better displaying syntax trees.
Before
After:
