Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): fixup ts module loader #1010

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jun 13, 2024

Ready for review Powered by Pull Request Badge

Summary

Fixes and closes #824, relating to the TypeScript module loader.

Changelog

  • fix: truffle boundary for native ts module loader
  • chore: general typescript cleanup

- fix: truffle boundary for native ts module loader
- chore: general typescript cleanup

Fixes and closes #824

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon added bug Something isn't working lang:typescript Language features relating to TypeScript labels Jun 13, 2024
@sgammon sgammon added this to the Release R6: Alpha 10 milestone Jun 13, 2024
@sgammon sgammon requested a review from a team June 13, 2024 10:29
@sgammon sgammon self-assigned this Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (9b3d37f) to head (86cdb09).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   54.59%   54.62%   +0.02%     
==========================================
  Files         320      320              
  Lines       10151    10159       +8     
  Branches     1759     1760       +1     
==========================================
+ Hits         5542     5549       +7     
  Misses       4078     4078              
- Partials      531      532       +1     
Flag Coverage Δ
gradle 54.62% <90.90%> (+0.02%) ⬆️
jvm 54.62% <90.90%> (+0.02%) ⬆️
lib 54.62% <90.90%> (+0.02%) ⬆️
plugin 54.62% <90.90%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../elide/runtime/lang/typescript/JSRealmPatcher.java 66.66% <ø> (ø)
...de/runtime/lang/typescript/TypeScriptLanguage.java 90.90% <90.90%> (-1.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616f63d...86cdb09. Read the comment docs.

@sgammon sgammon merged commit fc36c63 into main Jun 13, 2024
21 checks passed
@sgammon sgammon deleted the fix/typescript-module-loader branch June 13, 2024 18:59
This was referenced Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lang:typescript Language features relating to TypeScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TypeScript Support
2 participants