Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SSR Precompiling (JS) #16

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Feature: SSR Precompiling (JS) #16

merged 2 commits into from
Jun 29, 2022

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jun 28, 2022

Ready for review Powered by Pull Request Badge

This experimental changeset plans to implement precompilation through Prepack, and potentially compression, for assets embedded for SSR loading in app JARs.

More coming soon.

@sgammon sgammon added ✋ embargoed PRs and issues that can't proceed because of some non-code condition feature Large PRs or issues with full-blown features javascript Features and issues relating to JS labels Jun 28, 2022
@sgammon sgammon self-assigned this Jun 28, 2022
@elide-dev elide-dev deleted a comment from github-actions bot Jun 28, 2022
@elide-dev elide-dev deleted a comment from github-actions bot Jun 28, 2022
@elide-dev elide-dev deleted a comment from github-actions bot Jun 28, 2022
@elide-dev elide-dev deleted a comment from github-actions bot Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #16 (b46ea71) into v3 (43b1aba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                 v3      #16   +/-   ##
=========================================
  Coverage     59.45%   59.45%           
  Complexity      166      166           
=========================================
  Files            33       33           
  Lines          1349     1349           
  Branches        132      132           
=========================================
  Hits            802      802           
  Misses          526      526           
  Partials         21       21           
Impacted Files Coverage Δ
...alvm/src/main/kotlin/elide/server/SSRExtensions.kt 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b1aba...b46ea71. Read the comment docs.

Base automatically changed from feat/java-17 to v3 June 28, 2022 09:46
This experimental changeset plans to implement precompilation
through Prepack, and potentially compression, for assets embedded
for SSR loading in app JARs.

Changes enclosed:
- Add `prepack` dependency to `graalvm-react`
- Run `prepack` against built code, switch outputs to embed it
- Change default symbol to `.pack.js` variant
@sgammon sgammon removed the ✋ embargoed PRs and issues that can't proceed because of some non-code condition label Jun 29, 2022
@sgammon sgammon marked this pull request as ready for review June 29, 2022 00:05
@sgammon sgammon merged commit 4168ba8 into v3 Jun 29, 2022
@sgammon sgammon deleted the feat/js-prepack branch June 29, 2022 00:06
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Large PRs or issues with full-blown features javascript Features and issues relating to JS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants