fix: typescript support #968
Conversation
- fix: typescript compiler and js realm/context use - fix: invocation of typescript from entrypoint - fix: module loader requires access to disk Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added
bug
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 54.81% 54.87% +0.05%
==========================================
Files 391 391
Lines 11537 11547 +10
Branches 1918 1918
==========================================
+ Hits 6324 6336 +12
+ Misses 4661 4659 -2
Partials 552 552
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| // on SVM, we should load the library directly using our own tools; this is because sqlite3 may be built into the | ||
| // binary statically, and loaded via our own facilities at build-time. | ||
| if (ImageInfo.inImageCode()) NativeLibraries.resolve(SQLITE3_LIBRARY) { | ||
| org.sqlite.SQLiteJDBCLoader.initialize() | ||
| } else { | ||
| // otherwise, on JVM, we should load the library through regular SQLite3 JDBC mechanisms; this will unpack the | ||
| // library to a temporary location, load it, and then clean up after itself. | ||
| NativeLibraries.resolve(SQLITE3_LIBRARY) { |
There was a problem hiding this comment.
Is this change meant to be part of this PR? Seems related to SQLite instead.
There was a problem hiding this comment.
Yes, it's related -- fixes for native libs
Summary
Fixes TypeScript support from the entrypoint; fixes the TypeScript module patcher which allows for TypeScript-native imports.
Changelog