Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fix:81 Mark emails as read #83

Closed
wants to merge 4 commits into from

Conversation

Shalom2212
Copy link

Created a mail read and unread function
added a button in ActionButtons where a user can Read or Unread a mail
contribute:issue #81 (1)
contribute:issue #81 (2)

Copy link

vercel bot commented Jan 7, 2024

@Shalom2212 is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@elie222 elie222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Needs a bit of fixing.

Left a few comments about naming, misuse of React state and useMemo.

Also the most natural place to read in an email is when a row is clicked and a user has actually read the email.

apps/web/components/ActionButtons.tsx Outdated Show resolved Hide resolved
apps/web/components/ActionButtons.tsx Outdated Show resolved Hide resolved
apps/web/components/ActionButtons.tsx Outdated Show resolved Hide resolved
apps/web/utils/gmail/label.ts Outdated Show resolved Hide resolved
apps/web/utils/gmail/label.ts Outdated Show resolved Hide resolved
apps/web/utils/gmail/label.ts Outdated Show resolved Hide resolved
apps/web/utils/actions-client.ts Outdated Show resolved Hide resolved
apps/web/utils/actions.ts Outdated Show resolved Hide resolved
apps/web/components/email-list/EmailPanel.tsx Outdated Show resolved Hide resolved
apps/web/components/ActionButtons.tsx Outdated Show resolved Hide resolved
@Shalom2212
Copy link
Author

Thanks for the PR! Needs a bit of fixing.

Left a few comments about naming, misuse of React state and useMemo.

Also the most natural place to read in an email is when a row is clicked and a user has actually read the email.

Thank you For your comments, i'll fix it

@Shalom2212 Shalom2212 changed the title #issue:81 Mark emails as read #fix:81 Mark emails as read Jan 9, 2024
@Shalom2212
Copy link
Author

I made all the changes as you mentioned please review it, if any changes needed please comment it!!
Thank you

@Shalom2212 Shalom2212 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants