Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abort on unmount to get rid of potential memory leak #11

Merged
merged 1 commit into from
May 31, 2020
Merged

Add abort on unmount to get rid of potential memory leak #11

merged 1 commit into from
May 31, 2020

Conversation

joeydebreuk
Copy link
Collaborator

Prevents:

Warning: Can’t call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.03% when pulling 33210fb on joeydebreuk:add_abort_fetch_on_unmount into 380d74a on esphen:master.

@eliihen
Copy link
Owner

eliihen commented May 31, 2020

Looks great, thanks for the PR! Merging and releasing a new version soon

@eliihen eliihen merged commit 3445c68 into eliihen:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeydebreuk @coveralls @eliihen