Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for IdP Okta. #123

Merged
merged 13 commits into from
Jun 9, 2021
Merged

Add tests for IdP Okta. #123

merged 13 commits into from
Jun 9, 2021

Conversation

q-uint
Copy link
Collaborator

@q-uint q-uint commented May 31, 2021

Closes #114

@q-uint q-uint requested a review from jdeflander May 31, 2021 14:04
@q-uint q-uint self-assigned this May 31, 2021
@q-uint q-uint mentioned this pull request May 31, 2021
Closed
jdeflander
jdeflander reviewed Jun 1, 2021
View reviewed changes
internal/idp_test/util_test.go Outdated Show resolved Hide resolved
internal/patch/patch.go Outdated Show resolved Hide resolved
@q-uint q-uint requested a review from jdeflander June 1, 2021 12:39
jdeflander
jdeflander reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@jdeflander jdeflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically use the same casing for all letters of an abbreviation for Go identifiers, so I would rename IdP and idP to IDP and idp respectively.

internal/idp_test/idp_test.go Outdated Show resolved Hide resolved
internal/idp_test/idp_test.go Outdated Show resolved Hide resolved
internal/idp_test/idp_test.go Outdated Show resolved Hide resolved
internal/idp_test/idp_test.go Outdated Show resolved Hide resolved
internal/idp_test/idp_test.go Outdated Show resolved Hide resolved
internal/patch/patch.go Outdated Show resolved Hide resolved
@q-uint q-uint requested a review from jdeflander June 4, 2021 05:39
@q-uint q-uint requested a review from jdeflander June 7, 2021 10:06
@q-uint q-uint merged commit 37836bb into master Jun 9, 2021
@q-uint q-uint deleted the pr/114/okta branch June 9, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdeflander jdeflander jdeflander approved these changes

Assignees

@q-uint q-uint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q-uint @jdeflander