Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete allophones from Letter #1393

Closed
Tracked by #106
nya-elimu opened this issue Aug 14, 2021 · 9 comments
Closed
Tracked by #106

Delete allophones from Letter #1393

nya-elimu opened this issue Aug 14, 2021 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@nya-elimu
Copy link
Member

nya-elimu commented Aug 14, 2021

Delete the allophones property from https://github.com/elimu-ai/webapp/blob/master/src/main/java/ai/elimu/model/content/Letter.java

@nya-elimu nya-elimu added the good first issue Good for newcomers label Aug 14, 2021
@Shubham-Vishwakarma
Copy link
Contributor

How to identify if the code is not used?

@nya-elimu nya-elimu changed the title Delete unused code Delete allophones from Letter Aug 14, 2021
@nya-elimu
Copy link
Member Author

How to identify if the code is not used?

@Shubham-Vishwakarma You could use an IDE like IntelliJ, NetBeans or Eclipse for example?

@Shubham-Vishwakarma
Copy link
Contributor

Thanks @nya-elimuai
I would like to give this a try

@nya-elimu
Copy link
Member Author

@Shubham-Vishwakarma Great 🙂

Do you need any assistance with getting started?

@Shubham-Vishwakarma
Copy link
Contributor

I am reading the install.md to setup this
I dont have much exposure to java/maven

I will let you know if i get stuck any point

@Shubham-Vishwakarma
Copy link
Contributor

Shubham-Vishwakarma commented Aug 14, 2021

@nya-elimuai

/home/shubham/projects/webapp/src/main/java/ai/elimu/web/content/letter/LetterCsvExportController.java:[59,46] cannot find symbol
[ERROR] symbol: method getAllophones()
[ERROR] location: variable letter of type ai.elimu.model.content.Letter
[ERROR] /home/shubham/projects/webapp/src/main/java/ai/elimu/web/content/letter/LetterCsvExportController.java:[66,46] cannot find symbol
[ERROR] symbol: method getAllophones()
[ERROR] location: variable letter of type ai.elimu.model.content.Letter
[ERROR] /home/shubham/projects/webapp/src/main/java/ai/elimu/util/csv/CsvContentExtractionHelper.java:[150,23] cannot find symbol
[ERROR] symbol: method setAllophones(java.util.List<ai.elimu.model.content.Allophone>)
[ERROR] location: variable letter of type ai.elimu.model.content.Letter

getAllophones and setAllophones are been used in other classes?
What action is to be taken for these methods

@nya-elimu
Copy link
Member Author

getAllophones and setAllophones are been used in other classes?

@Shubham-Vishwakarma Yes. The getter and setter would have to be deleted as well. After you delete them, you can search for occurrences of letter.getAllophones and letter.setAllophones, and then delete those lines of Java code. Also, I recommend you search for occurrences of letter.allophones which would show you JSP (UI) code to delete as well.

@UmenR Please correct me if I'm forgetting anything.

Shubham-Vishwakarma added a commit to Shubham-Vishwakarma/webapp that referenced this issue Aug 15, 2021
Shubham-Vishwakarma added a commit to Shubham-Vishwakarma/webapp that referenced this issue Aug 15, 2021
Shubham-Vishwakarma added a commit to Shubham-Vishwakarma/webapp that referenced this issue Aug 15, 2021
…ithub.com:Shubham-Vishwakarma/webapp into elimu-ai#1393-Closes-Delete-allphones-from-Letter
Shubham-Vishwakarma added a commit to Shubham-Vishwakarma/webapp that referenced this issue Aug 15, 2021
Shubham-Vishwakarma added a commit that referenced this issue Aug 15, 2021
…-allphones-from-Letter

#1393 Closes Delete allphones from Letter
@nya-elimu
Copy link
Member Author

@Shubham-Vishwakarma Before closing this issue, could you please also delete the "Audio" text from the aside (right column)?: http://hin.test.elimu.ai/content/letter/edit/10

Screen Shot 2021-08-15 at 2 59 27 PM

@nya-elimu
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants