-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Code to use getOrDeafult #1416
Refactor Code to use getOrDeafult #1416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this improvements. The less code, the better 🙂
Have you been able to test that the changes work properly by manually changing the CRON job time in the @Scheduled
annotations?
src/main/java/ai/elimu/tasks/LetterSoundCorrespondenceUsageCountScheduler.java
Outdated
Show resolved
Hide resolved
@nya-elimuai Just for test evidence Before: After: The count looks same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Ready to be merged 👍
#1275