-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(jetty): upgrade to 10.0.21 #1683
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=========================================
Coverage 15.03% 15.03%
Complexity 452 452
=========================================
Files 249 249
Lines 7760 7760
Branches 812 812
=========================================
Hits 1167 1167
Misses 6541 6541
Partials 52 52 ☔ View full report in Codecov by Sentry. |
WalkthroughThis update enhances the documentation by adding deployment instructions to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
src/main/config/DEPLOY.md (5)
7-7
: Add a missing comma after "In this example".A comma is required to improve readability.
- In this example we will be using [CentOS](https://www.centos.org), + In this example, we will be using [CentOS](https://www.centos.org),Tools
LanguageTool
[typographical] ~7-~7: It appears that a comma is missing.
Context: ...erver. ## Operating System 🔆 In this example we will be using [CentOS](https://www.c...(DURING_THAT_TIME_COMMA)
37-37
: Format the bare URL.To conform with Markdownlint rules, format the bare URL.
- You can find the download links for each release at https://jetty.org/download.html + You can find the download links for each release at [Jetty Downloads](https://jetty.org/download.html)Tools
Markdownlint
37-37: null
Bare URL used(MD034, no-bare-urls)
120-120
: Format the bare URL.To conform with Markdownlint rules, format the bare URL.
- Configure a YUM repo entry for your OS at https://mariadb.org/download/?t=repo-config. + Configure a YUM repo entry for your OS at [MariaDB Repository Configuration](https://mariadb.org/download/?t=repo-config).Tools
Markdownlint
120-120: null
Bare URL used(MD034, no-bare-urls)
169-171
: Fix the code block style for SQL commands.To conform with Markdownlint rules, use indented code blocks for SQL commands.
- ```sql - CREATE DATABASE `webapp-HIN` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin; - ``` + CREATE DATABASE `webapp-HIN` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin;Tools
Markdownlint
169-169: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
175-179
: Fix the code block style for SQL commands.To conform with Markdownlint rules, use indented code blocks for SQL commands.
- ```sql - USE `webapp-HIN`; - CREATE USER '**********'@'localhost' IDENTIFIED BY '**********'; - GRANT ALL ON `webapp-HIN`.* TO '**********'@'localhost'; - ``` + USE `webapp-HIN`; + CREATE USER '**********'@'localhost' IDENTIFIED BY '**********'; + GRANT ALL ON `webapp-HIN`.* TO '**********'@'localhost';Tools
Markdownlint
175-175: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
closes #1656