Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libloading to 0.8 #20

Closed
wants to merge 1 commit into from
Closed

Conversation

ids1024
Copy link

@ids1024 ids1024 commented May 15, 2023

No description provided.

@elinorbgr
Copy link
Owner

Given this would bump the MSRV, this would technically be a breaking change. But the changes in libloading for 0.8 don't have any consequence on dlib, so I'd be inclined to set the dependency as libloading = ">= 0.7, < 0.9.

However I'm not sure if that might technically still be a breaking change?

@daxpedda
Copy link
Contributor

daxpedda commented Jun 5, 2023

I would argue that in the strictest sense it is a breaking change, anybody doing cargo update or initializing the dependency from scratch would get the newer libloading version.

But it depends on your MSRV policy of course.

@elinorbgr
Copy link
Owner

My question is rather whether in practice it could cause trouble or not.

Though I think I'm going to decide that, if you need a rustc version as old as < 1.48, surely you can go through the trouble of setting explicitly the dependency on libloading to 0.7 in your cargo.toml.

@elinorbgr
Copy link
Owner

Done in bc1466a

@elinorbgr elinorbgr closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants