Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Don't default to digitalocean provider #49

Closed
DavHau opened this issue Mar 5, 2020 · 0 comments
Closed

proposal: Don't default to digitalocean provider #49

DavHau opened this issue Mar 5, 2020 · 0 comments

Comments

@DavHau
Copy link
Contributor

DavHau commented Mar 5, 2020

Since Digital Ocean seems to be a special case, i think the default option should be something else

Out of all providers I have tested Digital Ocean seems to be the only one who needs the special network configuration. For all of the other providers it seemed to be better to use the normal routine.
But since nixos-infect defaults to digitalocean, i always have to specify PROVIDER=something for all other providers. This would be unnecessary if nixos-infect wouldn't default to digitalocean.

DavHau added a commit to DavHau/nixos-infect that referenced this issue Aug 21, 2020
@elitak elitak closed this as completed in 30441b1 Aug 21, 2020
Br1ght0ne pushed a commit to Holo-Host/holo-hydra-create that referenced this issue Feb 10, 2021
Should fix nameserver issue.

nixos-infect: curl -L to follow 301 redirect (elitak#55)

Improve providers fix dns (elitak#58)

* remove digitalocean as default; fix digitalocean dns; update channels

fixes elitak#53
fixes elitak#49

* fix doNetConf check

random fixes (elitak#63)

* use the nameservers

That variable was being set, but not used

* fix shellcheck issues

xzcat dep check

nameserver parsing fix

removing some cruft

rewrite loopback namservers to 8.8.8.8

Prefer to if to '&&' (elitak#64)

doNetConf check always true

Co-authored-by: Eric Litak <elitak@gmail.com>

avoid using NIX_PATH in resulting hardware-configuration.nix (elitak#65)

This makes the resulting hardware-configuration.nix usable from a system
that is a nix flake without having to replace that usage of NIX_PATH first.
Br1ght0ne pushed a commit to Holo-Host/holo-hydra-create that referenced this issue Feb 10, 2021
Should fix nameserver issue.

nixos-infect: curl -L to follow 301 redirect (elitak#55)

Improve providers fix dns (elitak#58)

* remove digitalocean as default; fix digitalocean dns; update channels

fixes elitak#53
fixes elitak#49

* fix doNetConf check

random fixes (elitak#63)

* use the nameservers

That variable was being set, but not used

* fix shellcheck issues

xzcat dep check

nameserver parsing fix

removing some cruft

rewrite loopback namservers to 8.8.8.8

Prefer to if to '&&' (elitak#64)

doNetConf check always true

Co-authored-by: Eric Litak <elitak@gmail.com>

avoid using NIX_PATH in resulting hardware-configuration.nix (elitak#65)

This makes the resulting hardware-configuration.nix usable from a system
that is a nix flake without having to replace that usage of NIX_PATH first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant