Fix hardcode of eth0 in several places #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that some VPS (from GigaCloud provider, Ukraine) provided `ens3` interface name, but after infection it was renamed to `eth0` via udev rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that some VPS (from GigaCloud provider, Ukraine) provided
ens3interfacename, but after infection it was renamed to
eth0via udev rules.This fixes hardcode in two ways:
networking.usePredictableInterfaceNamesexplicitlyI thinkg, both approaches can replace each other (and work in combo too). So, we can leave udev rules and drop usePredictableInterfaceNames, leave usePredictableInterfaceNames and drop udev rules, or leave both. I've chose the last variant here, because I can't test this on Digital Ocean.
Also, this partially overlaps with #17 (and maybe closes it).