Implemented missing tricks for BiaffineParser, now PTB UAS 95.55, LAS 94.48 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this pull request. Sorry for replying you late because of my busy works. |
|
Hello @hankcs I'm sorry for not coming back in a while. Due to our core API changes a lot, we might not be able to integrate your pull request in this stage really quick. Let's talk about this when we meet! I'm much appreciate your works. |
|
Hi Gary, that's fine. I'm working on the Gluon/MXNet porting of this parser, under Prof. Choi's instruction. Let's discuss it on campus later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Some tricks helping model generalize better.
Proposed Changes