Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Crawly.Engine.stop_all_spiders/0 #106

Closed
wants to merge 8 commits into from

Conversation

Ziinc
Copy link
Collaborator

@Ziinc Ziinc commented May 18, 2020

For #37 , builds on #104

@Ziinc Ziinc requested a review from oltarasenko May 18, 2020 08:50
@Ziinc
Copy link
Collaborator Author

Ziinc commented Nov 2, 2020

Made all tests pass, the stop_all_spiders function just delegates to the existing stop_spider/2 function.

I also shifted down the on_spider_closed_callback execution position to be within the genserver call handler, so that we only execute the callback if the spider was closed (and not if the spider was not running and was not "closed" by the engine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants