Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry support #47

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Retry support #47

merged 1 commit into from
Jan 13, 2020

Conversation

oltarasenko
Copy link
Collaborator

@Ziinc I have re-implemented the https://github.com/oltarasenko/crawly/pull/39/commits as we have discussed in original PR.

@oltarasenko
Try to fetch unsuccessful requests more then once. The amount
6d0f911 
of attempts is controlled by the max retries setting.
Ziinc
Ziinc approved these changes Jan 13, 2020
View reviewed changes
Copy link
Collaborator

@Ziinc Ziinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only comment is that the worker_test.exs seems quite verbose, looks more like an integration test (since it tests the storage worker as well) instead of a unit test for only worker.ex.

@Ziinc Ziinc merged commit 8d78f06 into master Jan 13, 2020
@Ziinc Ziinc mentioned this pull request Jan 13, 2020
Closed
@dogweather dogweather deleted the new_re_tries branch December 14, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziinc Ziinc Ziinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oltarasenko @Ziinc