Convert structs that implement the Enumerable protocol to lists #4432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it surprising that I could not use a
MapSet
or anotherEnum
when usingin
in a query as I expected it to function similarly toKernel.in/2
.This PR checks for an implementation of the
Enumerable
protocol and converts it to a list when casting, returning an error if there is none.If this isn't the direction you want Ecto to go, I'm happy to have this closed. Otherwise, let me know anything else I should be mindful of or any documentation I should update.
Thanks!