Add "schedule" annotation to NIF functions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to classify most of the NIF functions as possible "dirty". For smaller sets, those functions should not take more than 1 millisecond to perform. But for larger datasets, it's probably going to take more time. This follows the recommendations from: https://www.erlang.org/doc/man/erl_nif.html#lengthy_work Also see rusterlium/rustler#402
cigrainger
approved these changes
Mar 31, 2022
|
@cigrainger btw, once the backend becomes lazy, you only need those annotations in the functions that do IO operations and the ones that compute. The regular functions do not need to be tagged. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to classify most of the NIF functions as
possible "dirty".
For smaller sets, those functions should not take more
than 1 millisecond to perform. But for larger datasets,
it's probably going to take more time.
This follows the recommendations from:
https://www.erlang.org/doc/man/erl_nif.html#lengthy_work
Also see rusterlium/rustler#402