Check if the current adapter supports DDL transaction #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Checks if the adapter supports ddl transaction. | ||
|
|
||
| """ | ||
| defcallback supports_ddl_transaction? |
There was a problem hiding this comment.
Let's also tag the return type as boolean:
defcallback supports_ddl_transaction? :: boolean
It was necessary to make it possible to add other adapters that doesn't have this feature. i.e MySQL -> http://dev.mysql.com/doc/refman/5.0/en/cannot-roll-back.html
laurocaetano
force-pushed
the
check-ddl-transactions
branch
from
825b25d
to
9860c36
Compare
|
|
||
| @doc false | ||
|
|
||
| def supports_ddl_transaction? do |
There was a problem hiding this comment.
@josevalim I just moved the supports_ddl_transaction? function to the Ecto.Adapters.Postgres module. The problem now is that we are defining the behaviour inside the Ecto.Adapter.Migrations module and it will warn us that it is not implemented. Shall we move this behaviour definition to another place?
josevalim
added a commit
that referenced
this pull request
Feb 11, 2015
Check if the current adapter supports DDL transaction
|
😻 |
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary to make it possible to add other adapters that doesn't
have this support. i.e MySQL -> http://dev.mysql.com/doc/refman/5.0/en/cannot-roll-back.html
cc/ @josevalim