Behaviour as runtime dependency #12103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
behaviour_as_runtime_dependency
branch
from
0040270
to
c0c2d65
Compare
marcandre
changed the title
|
PR ready for review. I presume the Windows OTP-25 failure is not related |
josevalim
reviewed
Aug 29, 2022
josevalim
reviewed
Aug 29, 2022
josevalim
reviewed
Aug 29, 2022
josevalim
reviewed
Aug 29, 2022
There was a problem hiding this comment.
This is fantastic @marcandre, thank you! ❤️ I have dropped 3 comments but they are all nitpicks about renaming/moving code around. :)
|
Great, thank you 😄 |
marcandre
force-pushed
the
behaviour_as_runtime_dependency
branch
from
c0c2d65
to
860648d
Compare
Processing unchanged
This will make it easier to also build a list of warnings
marcandre
force-pushed
the
behaviour_as_runtime_dependency
branch
from
860648d
to
839589f
Compare
|
@josevalim tweaks done |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
@behaviourdeclarations introduce only a runtime dependency instead of a compile-time.The checks are moved from the module compiler to the parallel checker.
This requires storing the
@implstatements as well as the list of@behaviours when compiling the module, for later retrieval when doing the checks.Remains to be done:@behaviour :"Elixir.MyModule"does not (yet) introduce a runtime dependency at all and so it is possible that further changes toMyModulewill not trigger checks for modules implementing it.Notes:
behaviourcode to a newModule.Behaviourmodule, but that's not necessary and code could easily be moved back intoModule