-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use seed
to randomize require order of test files
#12442
Conversation
options = persist_defaults(configuration()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to be outside of Task.async
to ensure seed
was set when it's fetched in test.ex
lib/mix/test/mix/tasks/test_test.exs
Outdated
assert matches == [["ATest [test/a_test_stale.exs]"], ["BTest [test/b_test_stale.exs]"]] | ||
end) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those tests are rather expensive and they rely on implementation details-ish. I am thinking we could just skip them altogether? Other than that, the impl is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Let me remove the test.
@josevalim I considered updating the docs for the
Even with |
💚 💙 💜 💛 ❤️ |
Addresses https://groups.google.com/g/elixir-lang-core/c/yjs-zaFvZJc
Looking for feedback on implementation and testing strategy.
seed
argument