Add callout to full bitstring reference in the getting started guide. #13360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 22, 2024
lib/elixir/pages/getting-started/binaries-strings-and-charlists.md
Outdated
Show resolved
Hide resolved
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitstring constructor syntax reference
<<>>isn't easy for newcomers to discover. It's not SEO friendly and the getting started guide for bitstrings doesn't indicate that subtle link's the full reference.The old getting started guide on elixir-lang.org called out to it in plain English, and I think it's worth adding back in some form.
I've added it back in this PR at the bottom of the bitstring section in bold, in addition to removing the
/1from the<<>>/1link at the top.My impetus for this is, I saw a new person asking questions about bitstrings. They'd already been working with them a fair bit, going off blog posts and the getting started guide. They weren't aware the full syntax reference was available. Purely an anecdotal case, but I thought this worth proposing nonetheless.