Warn on unnecessary quotes

[josevalim]

Closes #7634

[josevalim]

Also, should it be :warn_on_unnecessary_quote or :warn_on_unnecessary_quotes? I went with the second but I thought I would double check.

[fertapric]

I would add a dot at the end and the default value to keep consistency with previous descriptions.

• :warn_on_unnecessary_quotes - when false, does not warn when atoms, keywords and calls have unnecessary quotes on them. Defaults to true.

[fertapric]

And maybe use "or" instead of "and"?

does not warn when atoms, keywords or calls have unnecessary quotes on them

[michalmuskala]

I like the feature and I also think warn_on_unnecessary_quotes is better.

[fertapric]

I think the documentation about the default value is handy :)

I just want to be sure that part was not overlooked from my previous comments. If you disagree, no worries :)

[josevalim]

I missed it. :) Tks for double checking.

[whatyouhide]

👏

[josevalim]

❤️ 💚 💙 💛 💜

[garazdawi]

I've been looking at barrel-db/rebar3_elixir_compile#37 and noticed that you no longer use Code.eval_string in Mix.Dep.Lock. From this I assume that it is intentional that you cannot turn off the warning when using Code.eval_string? So the rebar3 plugin should to the same thing?

[josevalim]

Yes, the rebar3 plugin should do the same. The options given to eval are not forwarded to string_to_quoted but you can just call it directly and put it all together. This approach should also be backwards compatibility. string_to_quoted and eval_quoted have been there forever!