Highlight digits in atoms #176
Conversation
| (one-or-more (any "a-z" "A-Z" "_" "\"" "'")) | ||
| (and | ||
| (any "a-z" "A-Z" "_" "\"" "'") | ||
| (zero-or-more (any "a-z" "A-Z" "0-9" "_" "\"" "'"))) |
There was a problem hiding this comment.
Why the change from one-or-more to zero-or-more? This doesn't make sense to me.
There was a problem hiding this comment.
The old regexp was:
(or
(one-or-more (any "a-z" "A-Z" "_" "\"" "'"))
...)Which matches only :msisdn in the :msisdn2pid atom, leaving 2pid unhighlighted as described in #172.
By changing it to
(or
(and
(any "a-z" "A-Z" "_" "\"" "'")
(zero-or-more (any "a-z" "A-Z" "0-9" "_" "\"" "'")))I ask for the first character in '("a-z" "A-Z" "_" "\"" "'") and the subsequent ones in '("a-z" "A-Z" "0-9" "_" "\"" "'"). This in turn matches the whole :msisdn2pid atom.
Sorry, I should've added more context to the PR.
|
Please just add a regression test for this change and it should be good to merge. |
|
Alright, will do. |
|
You can see an example here. |
|
@mattdeboard I have added the regression test for #172 as you requested. (also, why do we run |
|
@mattdeboard ert itself has some bugs WRT to display and buffer. See here for example: http://debbugs.gnu.org/db/16/16853.html Suggest to drop these --no-win tests. |
|
ping, Any more thoughts on this PR? Thanks! |
* Add changelog test to verify that the changelog is correctly linked * Update changelog * Add elixir-editors#497 * Specify that the fuzzy completion is only for functions * Fix formatting * update changelog for elixir-editors#505 * Update changelog for elixir-editors#501, elixir-editors#473, and elixir-editors#504 * Update changelog for #507 and vscode elixir-editors#176 * Update changelog for #511 * Update changelog for elixir-editors#492
Fixes #172