Skip to content

Conversation

tonini
Copy link
Contributor

@tonini tonini commented May 28, 2015

No description provided.

@mattdeboard
Copy link
Contributor

What does this fix?

@tonini tonini force-pushed the update-imenu-generic-expression branch from 50296a5 to ca65651 Compare May 28, 2015 16:37
@tonini tonini force-pushed the update-imenu-generic-expression branch from ca65651 to 3daef47 Compare May 28, 2015 16:44
@tonini
Copy link
Contributor Author

tonini commented May 28, 2015

The following will also be identified as a symbol

@doc false
defmacro __before_compile__(env) do
  plugs = Module.get_attribute(env.module, :plugs)
  {conn, body} = Plug.Builder.compile(env, plugs, [])

  quote do
>   defp phoenix_endpoint_pipeline(unquote(conn)), do: unquote(body)
  end
end
def broadcast(_, _, _, _, _), do: raise_invalid_message

And also functions with ! and ?

 def broadcast!(_, _, _, _), do: raise_invalid_message
 def broadcast?(_, _, _, _), do: raise_invalid_message

So now it wouldn't matter if it's a one-line definition or not and also the ! / ? will be handeled.

@mattdeboard
Copy link
Contributor

So does this fix #212?

@tonini
Copy link
Contributor Author

tonini commented May 28, 2015

Unfortunately no, it have nothing to do with the indentation.

@mattdeboard
Copy link
Contributor

I understand.

@mattdeboard
Copy link
Contributor

Once travis clears I'll merge it

@tonini
Copy link
Contributor Author

tonini commented May 28, 2015

👍 ❤️

mattdeboard added a commit that referenced this pull request May 28, 2015
remove do keyword to handle also oneline definitions
@mattdeboard mattdeboard merged commit 1e63148 into master May 28, 2015
@mattdeboard mattdeboard deleted the update-imenu-generic-expression branch May 28, 2015 18:38
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants